Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite reload loop #26

Open
maxyha opened this issue Jan 16, 2018 · 1 comment
Open

Infinite reload loop #26

maxyha opened this issue Jan 16, 2018 · 1 comment

Comments

@maxyha
Copy link

maxyha commented Jan 16, 2018

With enabled cookie acceptance when users scroll AND enabled site reload after cookie accept, the js-code starts to execute the cnHandleScroll function each time user scrolls down on the site below the number of pixels defined in OnScroll-setting, thus producing an infinite reload loop once user scrolled down below that level.

IMHO the binding $( window ).on( 'scroll', cnHandleScroll ); should only happen as long as 'cookie_notice_accepted' is not set. Once it is set, the scroll event should not be registered at all.

@bartoszarendt
Copy link
Contributor

thx, next release will inclulde a fix for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants