fix: FI-1574: last_block_index shall be leb128 encoded #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
THLO
reviewed
Nov 12, 2024
THLO
reviewed
Nov 12, 2024
THLO
previously approved these changes
Nov 12, 2024
Co-authored-by: Thomas Locher <[email protected]>
|
Related discussion on the forum. |
THLO
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ICRC-3 standard specifies that the
last_block_indexvalue in the certificate returned from theicrc3_get_tip_certificateendpoint shall be encoded using leb128. The value has until now been encoded as a Big Endian-encodedu64, but this PR proposes to change that to aleb128encoding as per the ICRC-3 standard.