Skip to content

Commit

Permalink
fix(ICRC_Rosetta): Set the ICRC Rosetta version correctly in the dock…
Browse files Browse the repository at this point in the history
…er tag (#2885)

The wrong variable was being read in the ICRC Rosetta release workflow,
leading to a docker release with a tag "v" being
[created](https://hub.docker.com/layers/dfinity/ic-icrc-rosetta-api/v/images/sha256-d6c959f579d7827c53abd5c3d4d3a32c73046f312033a4146541b8e2e5256f26?context=explore).
This PR proposes reading the `ICRC_ROSETTA_RELEASE_VERSION` variable in
the case of ICRC Rosetta.
  • Loading branch information
mbjorkqvist authored Nov 29, 2024
1 parent 3025f56 commit 58f0ed2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/rosetta-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ jobs:
shell: bash
run: |
set -euo pipefail
for tag in "v${ROSETTA_RELEASE_VERSION}" latest; do
for tag in "v${ICRC_ROSETTA_RELEASE_VERSION}" latest; do
bazel run --stamp --embed_label="$tag" //rs/rosetta-api/icrc1:push_ic_icrc_rosetta_image
done
git tag "icrc-rosetta-release-$ICRC_ROSETTA_RELEASE_VERSION" "${{ github.sha }}"
Expand Down

0 comments on commit 58f0ed2

Please sign in to comment.