Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ckbtc): reduce minter fee #2861

Merged
merged 12 commits into from
Dec 3, 2024
Merged

refactor(ckbtc): reduce minter fee #2861

merged 12 commits into from
Dec 3, 2024

Conversation

gregorydemay
Copy link
Member

@gregorydemay gregorydemay commented Nov 27, 2024 •
edited
Loading

Reduce minter fee for ckBTC withdrawals:

  1. Roughly divide the various constant factors involved in the computation of the minter fee by 2.
  2. Ensure that no transaction output, including the change output to the minter, has a value below the dust limit, which depends on the type of addresses used (294 sats for P2WPKH)

@gregorydemay gregorydemay added the CI_ALL_BAZEL_TARGETS Runs all bazel targets and uploads them to S3 label Nov 27, 2024
@gregorydemay gregorydemay marked this pull request as ready for review November 27, 2024 16:09
@gregorydemay gregorydemay requested a review from a team as a code owner November 27, 2024 16:09
@gregorydemay gregorydemay requested review from ninegua and THLO November 27, 2024 16:10
@gregorydemay gregorydemay requested a review from a team as a code owner December 2, 2024 09:36
@github-actions github-actions bot added the @idx label Dec 2, 2024
nmattia
nmattia approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@nmattia nmattia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp

@gregorydemay gregorydemay added this pull request to the merge queue Dec 3, 2024
Merged via the queue into master with commit 2e2fff1 Dec 3, 2024
24 checks passed
@gregorydemay gregorydemay deleted the gdemay/XC-234-update-ckbtc-fees branch December 3, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@THLO THLO THLO left review comments

@ninegua ninegua ninegua approved these changes

@nmattia nmattia nmattia approved these changes

Assignees
No one assigned
Labels
CI_ALL_BAZEL_TARGETS Runs all bazel targets and uploads them to S3 @cross-chain-team @idx refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gregorydemay @ninegua @nmattia @THLO