feat(sns): Bound number of entries in get_upgrade_journal response #2873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anchpop
force-pushed
the
@anchpop/bound-upgrade-journal
branch
from
a3e006d to
6fe93f3
Compare
anchpop
force-pushed
the
@anchpop/bound-upgrade-journal
branch
2 times, most recently
from
0df2482 to
f22e963
Compare
anchpop
force-pushed
the
@anchpop/bound-upgrade-journal
branch
from
f22e963 to
58c626e
Compare
anchpop
changed the title
rs/sns/governance/src/governance/advance_target_sns_version_tests.rs
Outdated
Show resolved
Hide resolved
rs/sns/governance/proto/ic_sns_governance/pb/v1/governance.proto
Outdated
Show resolved
Hide resolved
rs/sns/governance/src/governance/advance_target_sns_version_tests.rs
Outdated
Show resolved
Hide resolved
rs/sns/governance/src/governance/advance_target_sns_version_tests.rs
Outdated
Show resolved
Hide resolved
anchpop
force-pushed
the
@anchpop/bound-upgrade-journal
branch
6 times, most recently
from
e12e6c2 to
c8e949d
Compare
daniel-wong-dfinity-org
approved these changes
Dec 4, 2024
rs/sns/governance/proto/ic_sns_governance/pb/v1/governance.proto
Outdated
Show resolved
Hide resolved
anchpop
force-pushed
the
@anchpop/bound-upgrade-journal
branch
2 times, most recently
from
26201ba to
ebfe54d
Compare
anchpop
force-pushed
the
@anchpop/bound-upgrade-journal
branch
from
ebfe54d to
09ba8a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes NNS1-3416