This repository has been archived by the owner on Nov 19, 2024. It is now read-only.
RUN-636: Add call context instruction counter #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ic-interface-spec ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Dfinity-Bjoern
approved these changes
Jul 11, 2023
dfinity-berestovskyy
changed the title
|
LGTM, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current execution instruction counter (performance counter type 0) gets reset at the beginning of each execution, i.e. at the beginning or each call, callback, or a system task. This makes the async code profiling difficult, as the profiling data must be stored across executions and then consolidated.
This PR introduces a new per-call instruction counter (performance counter type 1) which is monotonically increasing across nested calls and await points, greatly facilitating the async code profiling and optimization.