From 0364da7bc156f1113bb301171cb747df656040c9 Mon Sep 17 00:00:00 2001 From: Andri Schatz Date: Mon, 28 Oct 2024 15:54:05 +0100 Subject: [PATCH] add bugfix learnings to readme and hacking (#2677) --- HACKING.md | 2 ++ README.md | 4 ++++ 2 files changed, 6 insertions(+) diff --git a/HACKING.md b/HACKING.md index 0caacb9afe..69b2f2430f 100644 --- a/HACKING.md +++ b/HACKING.md @@ -121,6 +121,8 @@ If you open a PR that isn't formatted according to `prettier`, CI will automatic We use `eslint` to check the frontend code. You can run it with `npm run lint`. +Please note that you will need to have bash 5 or later installed to run the e2e tests. You can check your bash version by running `bash --version`. + #### Canisters tests There are plenty of unit and integration tests that cover the different canisters of this repository which cover all the functionality that Internet Identity offer. diff --git a/README.md b/README.md index 1ced104633..85dd5a403f 100644 --- a/README.md +++ b/README.md @@ -69,6 +69,10 @@ To access Internet Identity or configure it for your dapp, use one of the follow * Chrome, Firefox: `http://.localhost:4943` * Safari: `http://localhost:4943?canisterId=` +#### Note on Apple Silicon + +If you are running into build issues on Apple Silicon (specifically, if rollup is trying to access @rollup/rollup-darwin-x64), try using nvm to install node. + ### Architecture Overview Internet Identity is an authentication service for the [Internet Computer][ic]. All programs on the Internet Computer are Wasm modules, or canisters (canister smart contracts).