-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sidebar for desktop layout on landing #1705
Conversation
…ity into da-desktop-layout
…ity into da-desktop-layout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's some padding/spacing that went missing here!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the whole page got narrower here, is that expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch! Il investigate!
screenshots/desktop/landing_4.png
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's a footer issue here; plus shouldn't there be a sidebar?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is an issue with position fixed on the screenshot thingy, at least it works in real life.
…ity into da-desktop-layout
replaced by #1732 |
Introduces the possibility to add a sidebar on desktop.
mainWindow
now comes with two more slotsslotSidebar
andslotSidebarDecoration
.slotSidebar
holds the main content of the sidebarslotSidebarDecoration
is used for the a visual of the dapps explorerFor now those only show marketing content, so they are completely hidden on mobile. This might change in the future if needed.
Notable CSS changes:
min-width
andmax-width
both set to40rem
by justwidth
: https://github.com/dfinity/internet-identity/pull/1705/files#diff-dfcfd73ef8243285e586ac8980bd197e24b434855418783109c0404283304b23L625-R668.l-wrap
styles are not applied to#pageContent
as well🟢 Some screens were added
🟡 Some screens were changed
🔴 Some screens were removed