Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sidebar for desktop layout on landing #1705

Closed
wants to merge 33 commits into from
Closed

Conversation

meodai
Copy link
Collaborator

@meodai meodai commented Jun 19, 2023

Introduces the possibility to add a sidebar on desktop.

mainWindow now comes with two more slots slotSidebar and slotSidebarDecoration.

  • slotSidebar holds the main content of the sidebar
  • slotSidebarDecoration is used for the a visual of the dapps explorer

For now those only show marketing content, so they are completely hidden on mobile. This might change in the future if needed.

Notable CSS changes:

Screenshot 2023-06-19 at 09 51 47


🟢 Some screens were added
🟡 Some screens were changed
🔴 Some screens were removed

@meodai meodai marked this pull request as ready for review June 19, 2023 09:04
@nmattia nmattia changed the title Desktop layout Add sidebar for desktop layout on landing Jun 19, 2023
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's some padding/spacing that went missing here!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the whole page got narrower here, is that expected?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! Il investigate!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a footer issue here; plus shouldn't there be a sidebar?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is an issue with position fixed on the screenshot thingy, at least it works in real life.

@meodai meodai closed this Jun 27, 2023
@meodai
Copy link
Collaborator Author

meodai commented Jun 27, 2023

replaced by #1732

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants