Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create WebAuthn flows based on device order (recently used). #2883

Merged
merged 5 commits into from
Feb 26, 2025

Conversation

sea-snake
Copy link
Contributor

@sea-snake sea-snake commented Feb 26, 2025

Create WebAuthn flows based on device order (recently used).

Changes

  • Simplify findWebAuthnFlows to simple mapping over devices that are expected to be in recently used order.
  • Remove findWebAuthnRpId and related methods since they're no longer needed

Tests

  • Added "should return flows in order of devices (recently used)" test
  • Removed all "findWebAuthnRpId" tests since method no longer exists

🟡 Some screens were changed

Copy link
Collaborator

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Already approving, minor comments

@sea-snake sea-snake enabled auto-merge February 26, 2025 15:25
@sea-snake sea-snake added this pull request to the merge queue Feb 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 26, 2025
@sea-snake sea-snake added this pull request to the merge queue Feb 26, 2025
Merged via the queue into main with commit e46afc8 Feb 26, 2025
67 checks passed
@sea-snake sea-snake deleted the sea-snake/webauthn-flows-based-on-recently-used branch February 26, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants