Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ConvertTo-ExcelXlsx] open XLS as read-only #1603

Merged
merged 3 commits into from
May 18, 2024

Conversation

edwardmiller-mesirow
Copy link
Contributor

@edwardmiller-mesirow edwardmiller-mesirow commented May 18, 2024

This could help prevent file locking issues. Also put everything in a try-finally to be extra sure that it will quit.

Just some extra guardrails.

see also: https://learn.microsoft.com/en-US/dotnet/api/microsoft.office.interop.excel.workbooks.open

I tested this locally and it works

@dfinke dfinke self-assigned this May 18, 2024
@dfinke dfinke merged commit a1418a3 into dfinke:master May 18, 2024
9 checks passed
@dfinke
Copy link
Owner

dfinke commented May 18, 2024

Thanks, looks good. Like the extras on the Excel object model.

@dfinke
Copy link
Owner

dfinke commented May 18, 2024

Published. Are you on the X platform? Let me know, when I post I can add. - Thanks again

@edwardmiller-mesirow edwardmiller-mesirow deleted the read-only branch May 18, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants