Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: update_event may change event time information #16

Open
wbi-ocd opened this issue Dec 6, 2024 · 0 comments
Open

BUG: update_event may change event time information #16

wbi-ocd opened this issue Dec 6, 2024 · 0 comments

Comments

@wbi-ocd
Copy link

wbi-ocd commented Dec 6, 2024

If event has a timezone specified, using update_event will shift event time of - TZ offset.

TEST

Create an event in tl with an tz offset update title using API -> time will be different

Fix

I'm not sure if this should be fixed in iris client on iris web.

IF fixed on iris clients:

replace

            "event_date": date_time.strftime('%Y-%m-%dT%H:%M:%S.%f') if date_time else event.get('event_date'),
            "event_tags": ','.join(tags) if tags else event.get('event_tags'),
            "event_tz": timezone_string if timezone_string else event.get('event_tz'),

by

            "event_date": date_time.strftime('%Y-%m-%dT%H:%M:%S.%f') if date_time else event.get('event_date_wtz'),
            "event_tags": ','.join(tags) if tags else event.get('event_tags'),
            "event_tz": timezone_string if timezone_string else event.get('event_tz'),

but it's a not really intuitive as it breaks the 1 to 1 mapping between retrieved event and updated object

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant