Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remarks on the modules development tutorial page #13

Open
c8y3 opened this issue Jan 13, 2023 · 0 comments
Open

Remarks on the modules development tutorial page #13

c8y3 opened this issue Jan 13, 2023 · 0 comments

Comments

@c8y3
Copy link
Contributor

c8y3 commented Jan 13, 2023

These remarks are all about the documentation page Processor modules, with respect to a v2.0.0-beta-1 version:

  • listing iris_dummy_module/IrisDummyConfig.py: module_version should be a string, rather than a float
  • likewise, it would be nice for the attribute _interface_version to have a string, rather than float type
  • listing iris_dummy_module/IrisDummyModule.py: the import which defines interface_conf is probably missing?
  • listing iris_dummy_module/IrisDummyModule.py, method hooks_handler has the wrong signature: it is missing the hook_ui_name.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant