Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code architecture improvement: socket IO #580

Open
c8y3 opened this issue Sep 11, 2024 · 0 comments
Open

Code architecture improvement: socket IO #580

c8y3 opened this issue Sep 11, 2024 · 0 comments
Labels

Comments

@c8y3
Copy link
Contributor

c8y3 commented Sep 11, 2024

Code related to socket IO could be grouped, since event handlers and emitters are part of the public API of the backend.

The proposition is to:

  • group all methods with annotation @socket_io.on in namespace app.blueprints.socket_io_event_handlers
  • decide some namespace and group all methods which call socket_io.emit in it (maybe app.iris_engine.socker_io.emitters? I am unsure what the app.iris_engine namespace is supposed to represent/contain)
@c8y3 c8y3 added the quality label Sep 11, 2024
@c8y3 c8y3 assigned whikernel and unassigned whikernel Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants