Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace custom installer with "jupyter kernelspec install" #35

Closed
andrus opened this issue Aug 25, 2024 · 0 comments · Fixed by #42
Closed

Replace custom installer with "jupyter kernelspec install" #35

andrus opened this issue Aug 25, 2024 · 0 comments · Fixed by #42
Milestone

Comments

@andrus
Copy link
Contributor

andrus commented Aug 25, 2024

We already had users confused by the installation process. I am still confused by the "config" documentation and would like to simplify it. How about we replace our install script with the standard jupyter kernelspec install? In other words, I don't see the point of customized kernels. A "vanilla" kernell, that can be customized later in a shell without a reinstall seems way cleaner. The advantages:

  • The user wouldn't need to locate the right Python installation, as jupyter will be doing the install
  • All the config options will only work as runtime variables reducing confusion as to the kernel behavior
@stariy95 stariy95 added this to the 1.0-M4 milestone Sep 6, 2024
stariy95 pushed a commit that referenced this issue Sep 12, 2024
 Replace custom installer with "jupyter kernelspec install" #35
stariy95 added a commit that referenced this issue Sep 12, 2024
  - rename `launcher` module to `jjava-launcher`
stariy95 added a commit that referenced this issue Sep 12, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants