Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content from alternative directories left unsaved. #9

Open
dgaspary opened this issue Apr 1, 2021 · 5 comments
Open

Content from alternative directories left unsaved. #9

dgaspary opened this issue Apr 1, 2021 · 5 comments

Comments

@dgaspary
Copy link
Owner

dgaspary commented Apr 1, 2021

How to reproduce:

-Create a file with a picture in LibreOffice writer.

-Open using LoadFromZipFile

-Save using SaveToZipFile

Trying to open the output file with LibreOffice will result in a document with an error frame due to the image not being added to the zip file.

@andresayang
Copy link

andresayang commented Apr 2, 2021

Hi again,

When working with zip files, mimetype is not written inside xml file but in a separated file "mimetype". That is the reason why we have exception with TOdfDocument.SaveToZipFile (if I do not load TOdfDocument with TOdfTextDocument).

Well, I do not know how you would like to process this: Maintain an xml file containing the list of extarcted file from original zip ?
Maybe I can help ...

Cheers

(Ps: I think you notice, from the file I sent you, I'm not located too far from you)

@dgaspary
Copy link
Owner Author

dgaspary commented Apr 2, 2021 via email

@andresayang
Copy link

Thx a lot

@dgaspary
Copy link
Owner Author

dgaspary commented Apr 2, 2021

I have uploaded the changes.

It's a initial support.

I believe I will have to test a lot of use cases like:

-Open with LoadFromSingleXml and save as package.

-Create and modify on memory then save as package. (priority)

The inverse cases of above.. and some more..

You can test and try to do what you need. When you find some problem, write here.

It can be a good point to start changind what is needed.

@andresayang
Copy link

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants