Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/pr tests issue 34 node 20 #50

Closed
wants to merge 12 commits into from

Conversation

dgrebb
Copy link
Owner

@dgrebb dgrebb commented Nov 26, 2023

Test for forthcoming PR to upstream from feature/34-node-20.

`genConfig` is now `makeConfig` and is ultimately used in `backstop init`. There is no need to test this separately, as it's part of the
overall flow of `init`, which is now used in npm's `integration-test` script, and passing.
…on, smoke, and sanity tests

This provides a final outcome message for all npm scripts for internal project testing. With tests that `exit 1`, a caution message is used, as opposed to a full-blown "FAIL".
also renames "docker-load" script "load-docker" to align with other script naming conventions
@dgrebb dgrebb self-assigned this Nov 26, 2023
@dgrebb dgrebb added documentation Improvements or additions to documentation enhancement New feature or request tests Testing-related tasks and enhancements. dependencies labels Nov 26, 2023
@dgrebb dgrebb added this to the Node Support (>=18.0.0) milestone Nov 26, 2023
@dgrebb dgrebb closed this Nov 26, 2023
@dgrebb dgrebb deleted the chore/pr-tests-issue-34-node-20 branch November 26, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies documentation Improvements or additions to documentation enhancement New feature or request tests Testing-related tasks and enhancements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant