Chore/downstream pr GitHub testing workflows #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgrebb
added
bug
dgrebb
force-pushed
the
chore/downstream-pr_github-testing-workflows
branch
from
94400ea to
640721a
Compare
Playwright doesn't self-install browsers in certain situations, so we ensure `npx playwright install --with-deps` is run within GitHub actions before attempting any tests.
dgrebb
force-pushed
the
chore/downstream-pr_github-testing-workflows
branch
from
640721a to
abc5159
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes playwright self-installation for CI.
Playwright needs to have
npx playwright install --with-depson GitHub actions runners. Not entirely sure when this became mandatory, but it's obnoxious, and needs to be done.https://playwright.dev/docs/ci-intro