Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates dependencies, refactors webpack, and makes adjustments as needed to get
build-compare
back in action.Here's a working, downstream build (not this branch).
Important
This PR should only be merged after garris/backstop-twentytwenty#6, which fixes webpack issues similar to this PR.
A broken import has been left in place of
backstop-twentytwenty
on line69
ofpackage.json
.Note
The recent blasphemous addition of
"type": "commonjs"
topackage.json
had webpack in a tizzy; throwing errors when using — GASP — esm in commonjs. More on that below.This is a good first step towards adding new features to the report UI.
eslint-plugin-n
stuck at15.x.x
untileslint-config-semistandard
updates their peerschalk
stuck at latest major4.1.0
"type": "commonjs"
must be removed frompackage.json
to avoid a webpack error:We can be filthy,
type
less, mixed-module scoundrels for now. I've removed"type": "commonjs"
frompackage.json
in this PR.Tested
npm run build-compare
npm run build-and-copy-report-bundle
npm run sanity-test
npm run sanity-test-playwright
npm run sanity-test-docker
npm run sanity-test-docker-playwright
Caveats
toggleTextInfo
, which is summarized in a question, belowQuestions
What is
toggleTextInfo
?compare/src/actions/index.js
does not definetoggleTextInfo
, and it's definitely called incompare/src/components/molecules/SettingsPopup.js
: