Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit 59c6a6f does not build on VS 2013 / VS 2015 #10

Open
ChaosCom opened this issue Dec 31, 2017 · 2 comments
Open

Commit 59c6a6f does not build on VS 2013 / VS 2015 #10

ChaosCom opened this issue Dec 31, 2017 · 2 comments

Comments

@ChaosCom
Copy link

Hello,

I've tried to compile the most recent build 59c6a6f on both VS 2013 as well as VS 2015 - without success.

Since the only 2 files that cause issues are PolynomialDivision.cs and PolynomialGcd.cs, I'm assuming it is due to the attempt to use tuples of the System.ValueTuple nuget package, for example

public static (MathObject quotient, MathObject remainder) PolynomialDivision(MathObject u, MathObject v, MathObject x)

Could you describe in detail how you made the project compile on VS 2013 / VS 2015 ?

@ChaosCom ChaosCom changed the title Build 59c6a6f does not build on VS 2013 / VS 2015 Commit 59c6a6f does not build on VS 2013 / VS 2015 Dec 31, 2017
@dharmatech
Copy link
Owner

Hello!

I haven't built with VS2013 or VS2015 in quite some time. I've been exclusively using VS2017.

@ChaosCom
Copy link
Author

ChaosCom commented Jan 1, 2018

Oh I see. Would it be perhaps possible for you to rewrite PolynomialDivision.cs and PolynomialGcd.cs so that they either use a custom PolynomialDivisionResult class (containing both fields) or use the framework System.Tuple class in order to retain compilation compatibility?

The commit before these 2 classes were introduced (2f7e681) still compiles under VS2013 with the Microsoft.Net.Compilers package (Version 1.3.2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants