Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: duplicate check for websites && check for a website #2

Open
tusharnankani opened this issue Jan 14, 2022 · 3 comments
Open

bug: duplicate check for websites && check for a website #2

tusharnankani opened this issue Jan 14, 2022 · 3 comments

Comments

@tusharnankani
Copy link

tusharnankani commented Jan 14, 2022

Duplicate check for websites.

image

Ah this is a fun problem ⬇
Edge cases:

image

Edit: Just saw, need a URL validator. I guess similar to what you built in the URL shortener.

image

@tusharnankani tusharnankani changed the title bug: duplicate check for websites bug: duplicate check for websites && check for a website Jan 14, 2022
@dheerajdlalwani
Copy link
Owner

  • Fixed the duplicate website issue & check for an actual website issue.
  • Just one thing: The format for adding a new website is: domain.tld
  • The extension currently does not support blocking specific pages of a website.
  • It either blocks the website completely or it does not block it.
  • Thank you so much for raising this issue 😄

@tusharnankani
Copy link
Author

Hey!

Need to reopen this.

image

But apparently, the checks could be better!

Ah this is a fun problem ⬇
Edge cases:

That's why I said this XD

@dheerajdlalwani
Copy link
Owner

Right, makes sense. Totally forgot about it..
Reopening this. Although I do expect the user to sort enter the website in the given format.
That's why the placeholder has a example.com
But yes, why not just improve the checks...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants