Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve issues found by static analysis (PVS) #243

Open
demoth opened this issue Jul 19, 2019 · 3 comments
Open

Resolve issues found by static analysis (PVS) #243

demoth opened this issue Jul 19, 2019 · 3 comments

Comments

@demoth
Copy link

demoth commented Jul 19, 2019

Hi Guys

I have run static analysis tool over the code of dhewm3 and found some suspicious places.
I hope this could help to find the real bugs. The list is not short and probably should be addressed in batches.

Attaching the report.
https://docs.google.com/spreadsheets/d/1cTJH3DNwhfsetZt-pTLb7nDr1SbHEcY8X377En9xBpc/edit#gid=170025750

@DanielGibson
Copy link
Member

Thanks a lot!

BTW, can you also run it on the Dentonmod branch of dhewm3-sdk? https://github.com/dhewm/dhewm3-sdk/tree/dentonmod
It seems to have some crashes that don't happen with the vanilla game (and are not always easy to reproduce), so maybe we're lucky and PVS finds the issues ;)

@demoth
Copy link
Author

demoth commented Jul 20, 2019

@DanielGibson done!
dhewm/dhewm3-sdk#11

@DanielGibson
Copy link
Member

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants