Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug or Feature Request: Publish GitHub tags with own files (dist) instead of whole project #91

Open
dalisoft opened this issue Dec 18, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@dalisoft
Copy link

Currently publishing Git releases & tags with separate tags but includes whole repository ZIP file with it's attached

@antongolub
Copy link
Collaborator

antongolub commented Dec 19, 2021

Hey, @dalisoft,

It's hard to say what’s going wrong.

  1. Multisemrel passes the pkg path as cwd option for each semrel process.

  2. Semrel uses cwd for its context.
    https://github.com/semantic-release/semantic-release/blob/971a5e0d16f1a32e117e9ce382a1618c8256d0d9/index.js#L248

  3. The plugin invokes glob with the same cwd value.
    https://github.com/semantic-release/github/blob/a283229652f180834b76734b87a613994c72ce06/lib/glob-assets.js#L28

As a workaround, I suggest specifying the paths in the plugin config.
https://github.com/semantic-release/github#usage

{
  "plugins": [
    "@semantic-release/commit-analyzer",
    "@semantic-release/release-notes-generator",
    ["@semantic-release/github", {
      "assets": [
        {"path": "dist/asset.min.css", "label": "CSS distribution"},
      ]
    }],
  ]
}

@antongolub antongolub added the bug Something isn't working label Dec 19, 2021
@dalisoft
Copy link
Author

@antongolub Thank you a lot for trying help, you can try this repo as testing, locally i have used multi-semantic-release and results are same. Seems this issue not much bug, it's more like help as even semantic-release, semantic-release-monorepo and similar tools also does same bug, but if your tool can do this right, it could be much much better than others.

For example,

  • go-to repository
  • go-to releases, pick one of package
  • try download Source and open
  • see, these ZIP/tar.gz includes whole package

It's possible include only related package files?

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants