Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Text Prefix and Suffix #2021

Open
CakeVR opened this issue Jan 13, 2024 · 5 comments
Open

Add Text Prefix and Suffix #2021

CakeVR opened this issue Jan 13, 2024 · 5 comments
Labels
Approved This can be added, but is not on any roadmap yet Feature✨
Milestone

Comments

@CakeVR
Copy link
Collaborator

CakeVR commented Jan 13, 2024

Is your feature request related to a problem? Please describe.
In most Visual Novels, text gets prefixed and suffixed by quotation marks.

Describe the solution you'd like
Allowing to define it on the character as an override or in the portrait settings as a default.

@Jowan-Spooner
Copy link
Member

Is this about text events? Then I think this should be a global setting not on characters or portraits? Maybe I'm missing the point though.

@CakeVR
Copy link
Collaborator Author

CakeVR commented Jan 14, 2024

Is this about text events? Then I think this should be a global setting not on characters or portraits? Maybe I'm missing the point though.

It allows you to specify how text gets pre- and suffixed based on who speaks. While the developer can use one symbol for quotation speech, they may also inject specific text effects based on the mood or portrait mode.

@Jowan-Spooner
Copy link
Member

I see, that does sound useful. I'm gonna put it on version 2.x milestone for now, but it can be implemented at any time you want, I treat those milestones more as: What needs to be done for version X.

@Jowan-Spooner Jowan-Spooner added this to the Version 2.X milestone Jan 15, 2024
@CakeVR
Copy link
Collaborator Author

CakeVR commented Jan 15, 2024

Yes, thanks, that milestone seems to fit better.

@Jowan-Spooner Jowan-Spooner added the Approved This can be added, but is not on any roadmap yet label Sep 13, 2024
@Jowan-Spooner
Copy link
Member

While we could add a default prefix and suffix, I think this is pretty much covered by the new character prefix and suffix system implemented in #2460 , right @CakeVR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved This can be added, but is not on any roadmap yet Feature✨
Development

No branches or pull requests

2 participants