Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back _array_data_external_data.archive_{format,path} data names. #47

Closed
wants to merge 1 commit into from

Conversation

jamesrhester
Copy link

@jamesrhester jamesrhester commented May 10, 2022

Supply tags left out of the 1.8.5 imgCIF update.

Closes #46

@yayahjb
Copy link
Collaborator

yayahjb commented May 11, 2022

I have been reviewing this pull request. I believe that we will need both the .archive_path tag as well as the .path tag as well as both the .archive_format take as well as the .format tag, since it is common practice to archive sets of data sets, with, say a bzipped tar, and still have each dataset be a multi-image container, e.g. hdf5 or even imgcif, which is
well able to carry multiple images in a single file. Ideally we should allow this to arbitrary
depth, but certainly at least to depth 2, so we can at least point to a tarball of hdf5 files

@jamesrhester
Copy link
Author

Yes, this is the intention of this pull request. The _array_data_external_data.{path,format} tags are already present in 1.8.5, just the archive_{format,path} ones were missing.

@yayahjb
Copy link
Collaborator

yayahjb commented May 12, 2022 via email

@yayahjb
Copy link
Collaborator

yayahjb commented May 13, 2022

Took care of this in new cif_img_1.8.6 just added to main

@yayahjb yayahjb closed this May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing some external_data items after merge into mainline
2 participants