Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accomodate for one or many misstrokes in the issue template #609

Open
Monniasza opened this issue Dec 14, 2024 · 0 comments
Open

Accomodate for one or many misstrokes in the issue template #609

Monniasza opened this issue Dec 14, 2024 · 0 comments

Comments

@Monniasza
Copy link

Monniasza commented Dec 14, 2024

Hi Mirabai. The issue template does not account grammatically for multiple misstroke entries.
It's annoying to edit the issue template every time I find more than one misstroke for one word. The current issue template reads:

Hello! Thanks for contributing! Your contribution will help new stenographers learn stenography and have a much better experience while they learn. Before you submit this issue, please check existing open and closed issues to make sure there are no duplicates. Feel free to use this template or start from scratch.

Dictionary

I noticed this dictionary entry or these dictionary entries in:

  • dict.json
  • dict-en-AU-with-extra-stroke.json

Misstroked entry or entries

This looks like a misstroke or could otherwise be better:

"TEFT/KP-PL/PHEUS/STROBG/EP/TREU": "example misstroke entry",
"TEFT/KP-PL/PHEUS/STROBG/EP/TREU/A*U": "example misstroke entry",

This looks like a misstroke because:

  • "test" does not appear in the translation, as suggested by TEFT.
  • "entry" is missing a B in EP for a phonetic stroke.
  • "entry" could use the brief SPWREU.
  • "mis" is not using the prefix stroke PHEUZ.
  • "stroke" is missing an E in STROEBG, which would be the phonetic, Plover theory stroke.
  • It could cause a conflict trying to write "test example misstroke entry".

Expected

I would expect the outline to be:

"KP-PL/PHEUZ/STROEBG/SPWREU": "example misstroke entry",

I would expect to see that outline because:

  • It uses a prefix stroke.
  • It is consistent with the main.json dictionary from Plover 3.
  • The phonetic stroke for "stroke" is written using STROEBG, which is consistent with the strokes used for "brushstroke", "heatstroke", and "sunstroke".
  • Mirabai says…

Even better

To make this even better, we could:

  • Remove the entry completely because it can already be stroked without its own entry. It is not a common phrase so it does not need to appear in dictionary look up searches.
  • Remove the stroke STROBG for "stroke" to be consistent with others, even though it is common in Plover theory to use the single vowel letter stroke when there's no other adjacent vowel in the translation.

There should be accomodations and the issue template can be made more compact, like this:

Hello! Thanks for contributing! Your contribution will help new stenographers learn stenography and have a much better experience while they learn. Before you submit this issue, please check existing open and closed issues to make sure there are no duplicates. Feel free to use this template or start from scratch.

Dictionary

I noticed this dictionary entry in:

  • dict.json

Misstroked entry

This looks like a misstroke or could otherwise be better:

"TEFT/KP-PL/PHEUS/STROBG/EP/TREU": "example misstroke entry",

This looks like a misstroke because:

  • "test" does not appear in the translation, as suggested by TEFT.
  • "entry" is missing a B in EP for a phonetic stroke.
  • "entry" could use the brief SPWREU.
  • "mis" is not using the prefix stroke PHEUZ.
  • "stroke" is missing an E in STROEBG, which would be the phonetic, Plover theory stroke.
  • It could cause a conflict trying to write "test example misstroke entry".

Expected

I would expect the outline to be:

"KP-PL/PHEUZ/STROEBG/SPWREU": "example misstroke entry",

I would expect to see that outline because:

  • It uses a prefix stroke.
  • It is consistent with the main.json dictionary from Plover 3.
  • The phonetic stroke for "stroke" is written using STROEBG, which is consistent with the strokes used for "brushstroke", "heatstroke", and "sunstroke".
  • Mirabai says…

Even better

To make this even better, we could:

  • Remove the entry completely because it can already be stroked without its own entry. It is not a common phrase so it does not need to appear in dictionary look up searches.
  • Remove the stroke STROBG for "stroke" to be consistent with others, even though it is common in Plover theory to use the single vowel letter stroke when there's no other adjacent vowel in the translation.

and

Hello! Thanks for contributing! Your contribution will help new stenographers learn stenography and have a much better experience while they learn. Before you submit this issue, please check existing open and closed issues to make sure there are no duplicates. Feel free to use this template or start from scratch.

Dictionary

I noticed these dictionary entries in:

  • dict.json
  • dict-en-AU-with-extra-stroke.json

Misstroked entries

These looks like misstrokes or could otherwise be better:

"TEFT/KP-PL/PHEUS/STROBG/EP/TREU": "example misstroke entry",
"TEFT/KP-PL/PHEUS/STROBG/EP/TREU/A*U": "example misstroke entry",

These looks like misstrokes because:

  • "test" does not appear in the translation, as suggested by TEFT.
  • "entry" is missing a B in EP for a phonetic stroke.
  • "entry" could use the brief SPWREU.
  • "mis" is not using the prefix stroke PHEUZ.
  • "stroke" is missing an E in STROEBG, which would be the phonetic, Plover theory stroke.
  • It could cause a conflict trying to write "test example misstroke entry".

Expected

I would expect the outline(s) to be:

"KP-PL/PHEUZ/STROEBG/SPWREU": "example misstroke entry",

I would expect to see that outline because:

  • It uses a prefix stroke.
  • It is consistent with the main.json dictionary from Plover 3.
  • The phonetic stroke for "stroke" is written using STROEBG, which is consistent with the strokes used for "brushstroke", "heatstroke", and "sunstroke".
  • Mirabai says…

Even better

To make these even better, we could:

  • Remove entries completely because they can already be stroked without their own entries. They're not a common phrase so they don'y need to appear in dictionary look up searches.
  • Remove the stroke STROBG for "stroke" to be consistent with others, even though it is common in Plover theory to use the single vowel letter stroke when there's no other adjacent vowel in the translation.

Also, there needs to be a default title, like:

example misstroke entry misstrokes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant