Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with menu #131

Open
filliperomero opened this issue Jan 14, 2021 · 3 comments
Open

Problem with menu #131

filliperomero opened this issue Jan 14, 2021 · 3 comments

Comments

@filliperomero
Copy link
Contributor

I saw that we are creating a menu in main.ts (electron) but this menu is not showing in Windows/linux (because of the custom Header). It only shows in Mac because MacOS handles different the menu.

The idea is to only show in MacOS or it is suppose to show in others platform?

If the answer is for all plataforms, I am thinking on fixing it putting the menu in the Header component but we don't a layout for it (one with the menu).
Some insights would be good, so I can work on it.

@diego3g
Copy link
Owner

diego3g commented Jan 15, 2021

Hi @filliperomero, i'm using Kubuntu and it shows the menu for me, but the user have to configure the Application Menu.
image
Will try to test it on windows, but i think that we can adapt Rocket Redis to work with the native header if the menu is that important to us :)

@filliperomero
Copy link
Contributor Author

hello @diego3g , looks like kubuntu has the same behavior as macos, putting the menu in the top of the screen.
So, we end up with this problem only in windows, since windows does not have a menu in the top corner.
image

We can get this menu and put in the custom header (vscode and hypder did that) if is that important for us to have this menu. We just need to think on how it will looks like on windows since the header has 2 layouts (mac style or normal style)

We can think about something like this:
Hyper (for when the mac style is active)
image
or we can go for a more classic layout like VSCode
image

Of course, all of these ideas are for windows only.

@diego3g
Copy link
Owner

diego3g commented Jan 15, 2021

That's great, i prefer the Hyper version as we have a custom header right now, what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants