Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small style change regarding editing widgets on front #417

Open
ardi-n opened this issue Oct 21, 2011 · 11 comments
Open

small style change regarding editing widgets on front #417

ardi-n opened this issue Oct 21, 2011 · 11 comments

Comments

@ardi-n
Copy link

ardi-n commented Oct 21, 2011

I would suggest to disable border for highlighted widgets because it brakes layout of the page. Instead we can use

#dm_page.edit .dm_widget .dm_widget_inner {
  outline: 2px groove #D3D3D3;
  border: none;
/*  border-radius: 0 4px 4px 4px;
  -moz-border-radius: 0 4px 4px 4px;
  -webkit-border-radius: 0 4px 4px 4px;*/
}

outline does not change box model.

@TheCelavi
Copy link
Member

I do not see the reason for this... rejected, sorry.

@jrencz
Copy link
Contributor

jrencz commented Dec 8, 2012

ardi-n: I do the same in each of my diem installs. IMO you're right - diem should not break the layout.

@TheCelavi
Copy link
Member

Ok, I see, but why not for Zone as well? Pull fix so we can merge it.

@TheCelavi TheCelavi reopened this Dec 8, 2012
@eXtreme
Copy link
Member

eXtreme commented Dec 8, 2012

It will break anyway because the "widget" handle is shown as well.

I fix this adding additionals CSS which disables floats and positions in edit mode to make it look "right".

@jrencz
Copy link
Contributor

jrencz commented Dec 8, 2012

Off course both widget and zone need to be restyled. In my case I changed 'widget' and 'zone' "tags" into little 1/4-circles with 'W' and 'Z' in it. They're placed in left and right corner respectingly.
Coupled with border-to-outline change it does the thing. No dimension is changed in edit mode at all

@jrencz
Copy link
Contributor

jrencz commented Dec 8, 2012

hmmm... seems like I can post an image too:
Screenshot 2012-12-08 at 23.05.21.png
here you can see widget with no body in zone which has slightly dimmed body in edit mode only

@eXtreme
Copy link
Member

eXtreme commented Dec 11, 2012

@jrencz can you share the code for that? Or is it just a concept? Because a widget div will overlay zone div making it impossible to click on "Z" to edit the zone

@jrencz
Copy link
Contributor

jrencz commented Dec 11, 2012

@eXtreme sure I do ;)
And it's clickable.
Should I make a pull request? Probably it's not ready for merging with Diem yet or anyway.
Maybe the right way is to make a plugin. I'll try to rewrite it into a plugin during Christmas break. Feel free to contact if you want to help: [email protected]

@eXtreme
Copy link
Member

eXtreme commented Dec 11, 2012

PR would be great, I'd like to test it myself.

@TheCelavi
Copy link
Member

@jrncs Would you be so kind and share your solution for this with us?

@jrencz
Copy link
Contributor

jrencz commented Jan 15, 2013

sorry, but I had (and for netx 3 weeks won't have probably) any time to separate it form my project.
It'll either have to wait or be closed for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants