Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to [vincefn.net](vincefn.net) not https secure #32

Open
connorjbracy opened this issue Dec 7, 2021 · 1 comment
Open

Link to [vincefn.net](vincefn.net) not https secure #32

connorjbracy opened this issue Dec 7, 2021 · 1 comment

Comments

@connorjbracy
Copy link
Contributor

In products/diffpycmi/contents: line 71, there is a link to "https://vincefn.net/ObjCryst/" which specifies the HTTPS protocol should be used but apparently this host does not support HTTPS. The linkcheck fails as the HTTPS request cannot be satisfied, but the link can still be reached by using the protocol agnostic link vincefn.net/ObjCryst/, although users may get a warning about accessing an insecure website. Ultimately, I think providing the link with or without the inclusion of the https:// portion will still properly direct users to the intended website, but including the https:// portion causes our linkcheck validation of the documentation update to fail.

@sbillinge, let me know if it is okay to change the reference link to this "insecure" format or what else should be done instead.

@sbillinge
Copy link
Contributor

sbillinge commented Dec 9, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants