New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement equality operator for wrapped classes #13

Open

2 tasks

pavoljuhas opened this issue Jun 16, 2017 · 0 comments

Open

2 tasks

implement equality operator for wrapped classes #13

pavoljuhas opened this issue Jun 16, 2017 · 0 comments

Member

pavoljuhas commented Jun 16, 2017

Crystal methods return wrappers to the same C++ instances, but they don't test for identity not equality:

>>>  nacl = loadObjCrystCrystal('NaCl.cif')
>>>  nacl.GetScatterer(0) is nacl.GetScatterer(0)
False
>>>  nacl.GetScatterer(0) == nacl.GetScatterer(0)
False
>>>  a = nacl.GetScatterer(0)
>>>  a.GetScatteringPower() is a.GetScatteringPower()
False
>>>  a.GetScatteringPower() == a.GetScatteringPower()
False

TODO

fix identity test if possible
fix equality operation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment