Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using deprecated pkg_resources #43

Open
vincefn opened this issue Nov 29, 2024 · 7 comments
Open

Stop using deprecated pkg_resources #43

vincefn opened this issue Nov 29, 2024 · 7 comments

Comments

@vincefn
Copy link
Collaborator

vincefn commented Nov 29, 2024

See the debian bug report and the notes in https://setuptools.pypa.io/en/latest/pkg_resources.html.

This should be replaced by importlib tools

@sbillinge
Copy link
Contributor

We have been updating all our diffpy packages for this and also changing how CI is handled. @vincefn we could do the same work on pyobjcryst of you like, to bring it in to line.

@sbillinge
Copy link
Contributor

Gentle ping @vincefn would you like to discuss this?

@vincefn
Copy link
Collaborator Author

vincefn commented Jan 7, 2025

Hi @sbillinge - sorry I had a complicated December and missed a number of followup messages.

Yes, please go ahead and make the required changes, it's internal so I don't think would affect end users.

@sbillinge
Copy link
Contributor

@bobleesj we have a green-light to cookiecut pyobjcryst. In general, I would like to change the name to diffpy.pyobjcryst, but this package has an existing user-base so this may be a bad idea, unless we can continue to ship it as pyobjcryst rather than diffpy.pyobjcryst. Because this is widely used, I would prefer if this was cookiecut by someone more experienced.....

@bobleesj
Copy link

bobleesj commented Jan 8, 2025

@sbillinge @vincefn

Noted. I created an issue to "cookiecut" while retaining the current way of importing this package

@vincefn
Copy link
Collaborator Author

vincefn commented Jan 9, 2025

Hmm - I thought this was about a mostly internal/import change.
I'm not so fond of the idea to change the name and visibility from just pyobjcryst, because I'd like to promote the use outside diffpy (even if the work from the diffpy project has to be properly recognised).

@sbillinge
Copy link
Contributor

Hmm - I thought this was about a mostly internal/import change. I'm not so fond of the idea to change the name and visibility from just pyobjcryst, because I'd like to promote the use outside diffpy (even if the work from the diffpy project has to be properly recognised).

That's ok (see discussion on #44 too), let's not change the name right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants