Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup and document modules #15

Open
jkozlowski opened this issue Jul 16, 2012 · 2 comments
Open

Cleanup and document modules #15

jkozlowski opened this issue Jul 16, 2012 · 2 comments
Labels
enhancement
Milestone
0.1

Comments

@jkozlowski
Copy link
Member

The code lives on 'cleanup' branch.
@jkozlowski
Copy link
Member Author

Test

@w-martin
Copy link
Member

w-martin commented Feb 3, 2013

Is this finished? Had a quick look through the code and it all seems documented

jkozlowski added a commit that referenced this issue Feb 18, 2013
@jkozlowski @w-martin
Cleanup.
5675714 
Documented Instruction.h.
Defined member values of instruction to be const.
Fixed constructors to deal with const values.
Fixed documentation in Instruction.h.
Added tests for create_copy_instruction and create_insert_instruction.
Added g_assert() to constructors, to make sure the parameters passed are sane.
Replaced calls to memcpy() with calls to g_memmove().
Defined copy_range struct, to be able to define a union inside instruction struct.
Small formatting changes.
closes #15
@w-martin w-martin mentioned this issue Feb 18, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.1
Development

No branches or pull requests
2 participants
@w-martin @jkozlowski