Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AttachPlayer loosing interactivity #19

Open
girayk opened this issue Oct 2, 2024 · 3 comments
Open

AttachPlayer loosing interactivity #19

girayk opened this issue Oct 2, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@girayk
Copy link
Contributor

girayk commented Oct 2, 2024

When we call Composition.attachPlayer its creating new canvas 2D element and its not binding some pixi events such as onmouseleave
Maybe its better instead of creating new Canvas element, returning renderer.view.canvas then we can bind reactivities.

public attachPlayer(element: HTMLElement) { element.appendChild(this.renderer.view.canvas); }

@k9p5
Copy link
Contributor

k9p5 commented Oct 17, 2024

The reason why we don't use the Pixi canvas is so that we can change the resolution during rendering. Otherwise the canvas would be rescaled. But I agree that we should propagate the events

@girayk
Copy link
Contributor Author

girayk commented Oct 17, 2024

👍🏻

@girayk girayk closed this as completed Oct 17, 2024
@k9p5
Copy link
Contributor

k9p5 commented Oct 18, 2024

I'll leave it open until the changes were merged

@k9p5 k9p5 reopened this Oct 18, 2024
@k9p5 k9p5 self-assigned this Oct 23, 2024
@k9p5 k9p5 added the enhancement New feature or request label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants