Fix serial socket, minor cleanups #120
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The socket driver erroneously acts like a modem on disconnect unconditionally, even when told not to. Correct that (fixes digarok#118)
The move to CMake should probably greatly change the contents of .gitignore, but for the time being let's add build to the mix.
The comments for Command/Option were reversed for PC and Mac standards. Fixed that. Ideally one ought to be able to configure modifier keys more flexibly and these would be merely the platform defaults, but … that's a job for another time.
Looks like digarok has most recently worked on another branch which has the .gitignore change in a different spot in the tree. Match that here.
|
Should I retarget this at a different branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #118 (tested with ProTERM). Also added build/ to .gitignore for CMake and flipped a couple of backwards comments for key designations in the SDL2 driver's keyboard handling.
Looks like vim auto-trimmed a little trailing whitespace while I was editing in those files as well.