Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme-builder for smaller screens #3232

Closed
Febakke opened this issue Feb 26, 2025 · 4 comments
Closed

Theme-builder for smaller screens #3232

Febakke opened this issue Feb 26, 2025 · 4 comments
Assignees
Labels
♿️ accessibility Issues related to accessibility 🕵️ investigate Needs investigation 🎨 theme-builder Everything related to our theme builder

Comments

@Febakke
Copy link
Member

Febakke commented Feb 26, 2025

Right now we are breaking WCAG guidelines with our... special handling of smaller screen sizes in our theme builder.

I got a feeling most people that are creating and building colorscales for code and Figma are using a bigger screen size. But if you are browsing our page with a phone it is a little weird that it totally fails when entering the theme builder.

Image

My suggestion is to make a alternative view for smaller screens that only show some important elements for browsing.

@Febakke Febakke added ♿️ accessibility Issues related to accessibility 🎨 theme-builder Everything related to our theme builder 🕵️ investigate Needs investigation labels Feb 26, 2025
@mrosvik
Copy link
Member

mrosvik commented Mar 4, 2025

Suggestion from @Barsnes ; Use dialog on mobile to open the content from sidebar

@mrosvik mrosvik moved this from 🔵 Inbox to 📄 Todo in Team Designsystemet Mar 4, 2025
@mrosvik
Copy link
Member

mrosvik commented Mar 4, 2025

@Febakke and @Thunear will create a suggestion

@Barsnes
Copy link
Member

Barsnes commented Mar 6, 2025

In PR #3294, the themebuilder was made usable for smaller screens. No work was done to check if the userflow is any good, it was just to fix big issues.

@mimarz
Copy link
Collaborator

mimarz commented Mar 11, 2025

We have fixed the most critical issues, but in reality this tool is not intended for use on smaller screens due to its nature and output.

Will look at potential other improvements in separate issues

@mimarz mimarz closed this as completed Mar 11, 2025
@github-project-automation github-project-automation bot moved this from 📄 Todo to ✅ Done in Team Designsystemet Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
♿️ accessibility Issues related to accessibility 🕵️ investigate Needs investigation 🎨 theme-builder Everything related to our theme builder
Projects
Status: ✅ Done
Development

No branches or pull requests

5 participants