Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duration misplaced on generated manifest #309

Open
cubap opened this issue Jul 18, 2019 · 3 comments
Open

duration misplaced on generated manifest #309

cubap opened this issue Jul 18, 2019 · 3 comments
Labels

Comments

@cubap
Copy link

cubap commented Jul 18, 2019

The downloaded Manifest based on my audio file (that is, the project was started on an audio file) appears to assign a duration on the audio annotation, but not to the Canvas itself.

The current 3.0 API insists:

A Canvas MUST have a rectangular aspect ratio (described with the height and width properties) and/or a duration to provide an extent in time.

There is, of course, no height or width attached to the Canvas, so a user has to add it themselves to be in compliance. I have not generated a branch for this or committed to a pull request to fix it at this time.

Additionally, though not correctly placed in its own issue, the target in the audio annotation was only identified as "canvas/c" instead of the complete "c1".

@stephenwf
Copy link
Member

Hi @cubap, thanks for the bug report!

Yes, I think there may also be a few more deviations from the 3.0 specification since it progressed from Alpha to Beta a few months ago. I will try to take a look at this soon, see if we can get the output manifests fully in spec.

I did try taking a manifest and putting it into the Universal viewer, which did show the ranges, but did not show the audio, and it sounds like the issues that you found here could be the cause!

Screenshot 2019-06-19 at 15 39 17

@cubap
Copy link
Author

cubap commented Jul 19, 2019

That's exactly right. Thanks for the attention and the work you've done!
If you want to point me at a component, I can generate a pull request this coming week, most likely.
As an aside, I'm not seeing the same thing at universalviewer.io. Is the P3 support something that isn't in the demo yet?

@stephenwf
Copy link
Member

The British Library are currently doing some work on the Universal Viewer to get good support for Audio + IIIF Presentation 3 into the UV. Here's a link to the staging site with one of the test manifests. If you scrub along the timeline you can see the annotations appearing below, and if you jump into full screen you'll see the ranges on the right hand side showing up (same as above).

I think the BL plan to get all of that work pushed back upstream into the UV, though the current UV should have some support for A/V.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants