Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readResponse method can hang if server unexpectedly disconnects #14

Closed
jdcockrill opened this issue Jul 18, 2014 · 1 comment
Closed

Comments

@jdcockrill
Copy link

The readResponse method is constructed such that if you are not at the "end" (determined by the code) and the Serial connection is not available, you can hang your application within the readResponse method indefinitely.

A timeout should be added that is long enough that it is unfeasible that the DigiX would have ever wanted to retrieve so much data anyway (15 seconds, the standard timeout in the header file) is probably sufficient.

@digistump
Copy link
Collaborator

Closed with commit 99acfdd thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant