Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: Move most of the tests to run under a single sandbox #96

Merged
merged 1 commit into from
Aug 3, 2020

Conversation

da-tanabe
Copy link
Contributor

@da-tanabe da-tanabe commented Aug 3, 2020

Move most of the tests to run under a single sandbox, but using different Parties.

The remaining tests that have not yet been moved over test more specialized features of dazl, so moving them over to a single sandbox instance is more complicated. Those will be addressed in a subsequent PR.

The TL;DR of the changes:

  • Introduce Network.aio_new_party and Network.simple_new_party, which imply an allocation of a new Party. Note that the current implementation does not yet actually call PartyManagementService, though it may in the future. It does, however, guarantee that new Party literals are created (via uuid), which is useful to keep the tests isolated from each other.
  • Hardcoded Party literals in tests have been removed.
  • Allow ensure_dar to be created before the Network is officially started.
  • Introduce an async_network helper method to remove some of the more tedious boilerplate around creating a Network, assigning it a URL, and uploading DARs (and then waiting for those DARs to be fully uploaded).

This is a precursor to switching the tests to run against DAML SDK 1.x (as outlined by #75). As an added benefit, the tests take 7.5 minutes to run instead of 10 minutes (since Sandboxes aren't repeatedly being restarted).

…ng different Parties.

The remaining tests that have not yet been moved over test more specialized features of dazl, so moving them over to a single sandbox instance is more complicated.
@da-tanabe da-tanabe marked this pull request as ready for review August 3, 2020 18:54
@da-tanabe da-tanabe merged commit e6ed243 into master Aug 3, 2020
@da-tanabe da-tanabe deleted the python-single-sandbox-tests branch August 3, 2020 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants