Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verein360 application data endpoint protection #1624

Open
f1sh1918 opened this issue Sep 9, 2024 · 2 comments
Open

Verein360 application data endpoint protection #1624

f1sh1918 opened this issue Sep 9, 2024 · 2 comments
Labels
Milestone

Comments

@f1sh1918
Copy link
Contributor

f1sh1918 commented Sep 9, 2024

Is your feature request related to a problem? Please describe.
Since this mutation is not behind an login, the mutation has to be protected.

Describe the solution you'd like

  • create a separate role "Verein 360" that can create api tokens
  • check if the api token has the correct access rights (is role Verein360 and project eak)
  • send insufficient permissions error and log the failed attempts
  • add the log pattern to fail to ban (salt) to ensure that after 5 failed attempts the ip will be blocked
@f1sh1918 f1sh1918 added the Task label Sep 9, 2024
@f1sh1918 f1sh1918 added this to the Verein360 milestone Sep 9, 2024
@f1sh1918
Copy link
Contributor Author

f1sh1918 commented Sep 9, 2024

@ztefanie not sure if we also have to add the possibility to create a user with this role via administration gui or it is sufficient to create it via runConfig and backend command, since we probably will only need one. Please check if there is anything to add in this ticket :)

@ztefanie
Copy link
Member

I think this user should also be able to be created via administration ui, it is not really effort for us to do this.

But in general I think it would be nice, if we move to a clean RBAC structure, i created a ticket for this here: #1626
we can discuss this at a grooming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

2 participants