Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

Cluster-add still assumes cluster/machines to be a list of id's #407

Open
rkoster opened this issue Jan 28, 2020 · 2 comments
Open

Cluster-add still assumes cluster/machines to be a list of id's #407

rkoster opened this issue Jan 28, 2020 · 2 comments

Comments

@rkoster
Copy link

rkoster commented Jan 28, 2020

The cluster-add task, adds the id of the current node to the cluster/machines param here

This works fine, however when visiting the cluster profile through the UI a validation error is shown. Because cluster/machines should be a list of objects.

Key 'cluster/machines': invalid val '[ca1b130d-2bc4-49ae-9922-313e5ccdde85 a8f32e7e-b8f1-4656-ab5b-e016b4488992 cf085c85-3e6f-4e2a-8cbb-2e4445262052]': 0: Invalid type. Expected: object, given: string 1: Invalid type. Expected: object, given: string 2: Invalid type. Expected: object, given: string
@zehicle
Copy link
Member

zehicle commented Jan 28, 2020

good catch.
the cluster-add task was missed when I adopted the KRIB cluster list pattern elsewhere.

@zehicle
Copy link
Member

zehicle commented Jan 28, 2020

at the moment, I believe this is a UX render issue but need to understand the impacts better.
the right solution is to move the code forward to use KRIB format instead of the simple list.

as a workaround, I'll make the object spec less specific and that should allow time for migrating the code.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants