-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It's not working anymore #48
Comments
This is likely because you need to set the Jekyll build environment to production. It defaults to development instead, and as a feature this gem only will run when the environment is set to production. For my build process, this makes sense. I have a test build script which is for debugging, and doesn't need to spend the extra time minimizing while generating my website. But when I do my production build, I want all of my HTML and JQuery to be minimized. So my build script will set the production environment variable when making the final website, and the development environment all other times. Hope that helps! See https://jekyllrb.com/docs/configuration/environments/ for details on build environments for Jekyll |
@gadgethm I'm running into the same issue despite having JEKYLL_ENV set. % echo $JEKYLL_ENV
production My config file is as follows - url: "http://enes100.umd.edu"
plugins:
- jekyll-sitemap
- jekyll-minifier
jekyll-minifier:
uglifier_args:
harmony: true Any ideas? |
Hmm... Try turning harmony off? On my setup I don't have that setting enabled. I also use a rakefile to set the build environment, but the command that is sent is essentially the following: You are also welcome to try my settings and see if that works better for you:
|
Exact same issue, jekyll 3.8.4.
in |
Does anyone know of a workaround? |
Same issue. |
Having the same issue.. |
the command i use is the following, it works with the only problem that only includes a single js file and i have 2
|
Doesn't work for me either, I debugged for a couple of hours and then gave up and just used Gulp after build, before deploy.
|
Same issue. Doesn't work. |
Same issue. Is this project dead? @gadgethm, I'd appreciate it if you let me know. Is this working for anyone? Also, does JEKYLL_ENV need to be set to "production" or production? (With the quotations or without?) |
I honestly haven't run this code on my website in ages at this point, I rarely update anymore. I'm afraid I'm probably too out of the loop to be much help. Given the quick look at the commit history for this project, I would say it seems to be fairly... well, dead tbh. Sounds like the best workaround idea is to use Gulp instead, though I haven't tried this. If I find some time to take a look, I'll see if I can come up with a forked solution, but honestly at this point it may be better to look for alternatives. Sorry @SamanDaneshvar. |
Hey there, a brief update since my last comment for anybody looking... We left Jekyll behind and rebuilt the @lesalonapp site in Hugo, several thousand pages in size, over the course of about 4 weeks last summer. It was really worth it and I now recommend moving to Hugo for anybody having issues with Jekyll |
Not working for me either. Using windows, and |
I can't get it to work, I've upgraded the bundler, and I've repeatedly run bundle update or install and reinstalled jekyll-minifier, but it doesn't solve the problem. 不能用+1。 |
This plugin is not working anymore for me.
No errors, just not minifying
Here is my _config.yml
The text was updated successfully, but these errors were encountered: