Cache file upload original names #35429
Open
+15
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimagimon
added
the
Risk: Medium
MartinRiese
force-pushed
the
riese/filename_broadcast
branch
2 times, most recently
from
a978dd1 to
f8e93c5
Compare
When deleting a repeat group we need to rebuild all the following groups because the IDs are reassigned by formplayer. Unfortunatly FP does not keep track of the original filename automatically and only sends the uuid based generated filename for the upload in the delete-repeat response. To be able to still display the original filename we store it in a map with the generated name as the key. That way we can figure out what it is when we rebuild that part of the UI.
MartinRiese
force-pushed
the
riese/filename_broadcast
branch
from
f8e93c5 to
751629b
Compare
MartinRiese
requested review from
AddisonDunn,
stephherbers,
Robert-Costello,
Jtang-1 and
nospame
as code owners
Robert-Costello
approved these changes
Nov 26, 2024
Jtang-1
reviewed
Nov 26, 2024
| self.fileNameDisplay(fixedNewValue); | ||
| self.answer(fixedNewValue); | ||
| } else if (cachedFilename) { |
There was a problem hiding this comment.
Do you know what the code above is doing? What situation is newValue an empty string vs constants.NO_ANSWER (null)?
if (newValue === "" && self.question.filename) {
self.question.hasAnswered = true;
self.fileNameDisplay(self.question.filename());
It looks like Minha added this previously here to solve a similar issue with the file question being rebuilt for question tiles. I'm not understanding why that doesn't solve the same issue here.
Jtang-1
reviewed
Nov 26, 2024
| @@ -938,7 +938,8 @@ hqDefine("cloudcare/js/form_entry/entries", [ | |||
| FileEntry.prototype = Object.create(EntrySingleAnswer.prototype); | |||
| FileEntry.prototype.constructor = EntrySingleAnswer; | |||
| FileEntry.prototype.onPreProcess = function (newValue) { | |||
| var self = this; | |||
| const self = this; | |||
| const cachedFilename = self.question.form().fileNameCache[self.answer()]; | |||
There was a problem hiding this comment.
what's the distinction between self.answer() and self.question.answer()?
There was a problem hiding this comment.
There is none. self.answer just references to self. question.answer
commitAdd condition I missed in last commitAdd condition I missed in last commitAdd condition I missed in last commitAdd condition I missed in last commitAdd condition I missed in last commitAdd condition I missed in last commit
Robert-Costello
approved these changes
Dec 6, 2024
minhaminha
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
When deleting a repeat group we need to rebuild all the following groups because the IDs are reassigned by formplayer. Unfortunately FP does not keep track of the original filename automatically and only sends the uuid based generated filename for the upload in the delete-repeat response. To be able to still display the original filename we store it in a map with the generated name as the key. That way we can figure out what it is when we rebuild that part of the UI.
Technical Summary
https://dimagi.atlassian.net/browse/USH-5078
Feature Flag
Safety Assurance
tested locally and on staging
Safety story
Automated test coverage
corehq/apps/cloudcare/static/cloudcare/js/form_entry/spec/form_ui_spec.js
QA Plan
Rollback instructions
Labels & Review