Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response doesn't always return full text causing error #6

Closed
sglkc opened this issue Apr 21, 2024 · 5 comments
Closed

Response doesn't always return full text causing error #6

sglkc opened this issue Apr 21, 2024 · 5 comments

Comments

@sglkc
Copy link
Contributor

sglkc commented Apr 21, 2024

Hi, thank you for the wonderful package!

Sadly it failed on parsing (at least for me), apparently the problem comes from core.js:318

I'm trying to get the new values right, but it might take a while. Here's my version of the object inside AF data callback obj_clean.json

I don't know if the response changed for everyone else 🤔

@sglkc
Copy link
Contributor Author

sglkc commented Apr 21, 2024

Sorry I was wrong, I just tried shrimple.png and it works. The problem is only for Japanese texts

@dimdenGD
Copy link
Owner

can you give image that errors

@sglkc sglkc changed the title Breaking change: Response data structure changed Cannot parse images with Japanese text Apr 21, 2024
@sglkc
Copy link
Contributor Author

sglkc commented Apr 21, 2024

after further testing, sometimes it works, and sometimes not. i don't know what makes this happen, changing images and network doesn't help.

then i found the main problem

the response doesn't always return the full text.

quick debugging

json test

Here's the passing and failing response json.
jp-fail.json
jp-pass.json

manga image

mangatest5

Edit: it affects images in other languages too, so I think the problem is on Google's side

@sglkc sglkc changed the title Cannot parse images with Japanese text Response doesn't always return full text causing error Apr 21, 2024
@dimdenGD
Copy link
Owner

I made an update, check if it solves the issue

@sglkc
Copy link
Contributor Author

sglkc commented Apr 21, 2024

Ah its perfect now, thank you so much. I was about to make a pr

@sglkc sglkc closed this as completed Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants