Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floor opening cuts mess with element sketch (Element Sketch Collector) #45

Open
TinaMTH opened this issue Apr 16, 2018 · 3 comments
Open

Comments

@TinaMTH
Copy link

TinaMTH commented Apr 16, 2018

Hi

I don't know that this is actually an issue with the Element Sketch Collector - it might be a Revit issue. But I'm curious to see, if there is a solution to this problem.
When I try to collect the element sketch of a floor with a floor opening cut (vertical opening), the output is the outline of one of the openings.

My current solution is to avoid using floor opening cuts, but that is not the most long lasting solution.

Thank you
##Tina

@TinaMTH
Copy link
Author

TinaMTH commented Apr 17, 2018

I can see where the problem comes from - The Element Sketch Collector relies on the correlation between Sketch Id and Element Id to be:
Sketch Id = Element Id -1

But when a floor opening cut is used, the Ids are shifted, and the sketch of one of the openings take over the Sketch Id of Element Id -1.

@dimven
Copy link
Owner

dimven commented Apr 24, 2018

I tried to be smart and add this as a workaround that avoids rolling back transactions, because that can be very slow on large files. Seems like it's not a solid option tho. I think it's best if there's another input controlling this behavior.

@TinaMTH
Copy link
Author

TinaMTH commented Apr 24, 2018

What I did find was, when I set the boolean to false, the curves came out correctly - so I did a very similar procedure to what you did in the script. I did a delete and roll back procedure to collect all the related Ids, then I filtered out the model lines by element name and matched them with the outlines I had found from the curves (found with your node) by the location of the centerpoints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants