Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searchbar's searching method. #9

Open
SotirisFtiakas opened this issue Mar 20, 2020 · 1 comment
Open

Searchbar's searching method. #9

SotirisFtiakas opened this issue Mar 20, 2020 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@SotirisFtiakas
Copy link
Collaborator

We need to specify how our searchbar is going to work.

Questions

  1. Real-time recommendations or no recommendations at all?
  2. Search of action-names only or search of locations, action-types and team-names(?) also supported?
  3. Auto-fill supported or not?
  4. Same or different searching method on the 4 existing searchbars? (Landing-page, Actions-page, Teams-page, Mobile-Navigation)
@SotirisFtiakas SotirisFtiakas added the enhancement New feature or request label Mar 20, 2020
@din0s din0s added the low priority This doesn't need to be worked on right now label Mar 22, 2020
@din0s din0s added this to the Working backend milestone Mar 22, 2020
@din0s
Copy link
Owner

din0s commented Jun 14, 2020

For the time being, the searching functionality is implemented in the front end instead of the backend. We can change that in the future if we deem that filtering in the frontend is too intensive of a task to be performed on render().

  1. Recommendations are possible if we send the user input before submitting it to the server, which will then return possible partial matches for the query.
  2. As of right now, we only look for case insensitive matches in the object's name or description.
  3. I'm not sure what you mean by autofill, this would be similar to real-time recommendations with what I have in mind.
  4. The searchbar component that's present in the navbar (both desktop and mobile view) simply redirects to the actions page. Between actions and teams, we should probably keep the same behavior so that the user "knows" what to anticipate.

@din0s din0s added documentation Improvements or additions to documentation and removed enhancement New feature or request low priority This doesn't need to be worked on right now labels Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants