Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks that columns relevant to the light curve class that must be in there to run have checks that they exist #5

Closed
mschwamb opened this issue Aug 5, 2023 · 2 comments · Fixed by #4
Assignees

Comments

@mschwamb
Copy link
Collaborator

mschwamb commented Aug 5, 2023

I think we should push the burden on these added functions to check that the relevant data frame columns exist since in the main bits of sorcha when the input files are initially read in, we won't know what columns are missing.

@drewoldag drewoldag self-assigned this Aug 9, 2023
@drewoldag
Copy link
Contributor

I believe that this is taken care of in PR #4. The user defined lightcurve or comet activity class also specifies which columns are required in the observations dataframe.

Before any computation happens, we make a call to self._validate_column_names() if the required column names are not present in the provided dataframe we'll raise an exception and log an error and raise and exception.

If that's insufficient, (or perhaps the incorrect action to take) then we can reopen this issue and address it in a different way.

@drewoldag drewoldag linked a pull request Aug 9, 2023 that will close this issue
@mschwamb
Copy link
Collaborator Author

Yep it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants