Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: remove code left by accident #1010

Merged
merged 1 commit into from
Aug 30, 2024
Merged

bugfix: remove code left by accident #1010

merged 1 commit into from
Aug 30, 2024

Conversation

mjuric
Copy link
Member

@mjuric mjuric commented Aug 30, 2024 •
edited by mschwamb
Loading

Fixes a problem identified on Slack where linking would fail with "ValueError: attempt to get argmin of an empty sequence."

Fixes #1009

Review Checklist for Source Code Changes

  • Does pip install still work?
  • Have you written a unit test for any new functions?
  • Do all the units tests run successfully?
  • Does Sorcha run successfully on a test set of input files/databases?
  • Have you used black on the files you have updated to confirm python programming style guide enforcement?

@mschwamb mschwamb merged commit 6d2867b into main Aug 30, 2024
3 of 7 checks passed
@mschwamb mschwamb mentioned this pull request Aug 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mschwamb mschwamb mschwamb approved these changes

@Gerenjie Gerenjie Awaiting requested review from Gerenjie

@astjoephysics astjoephysics Awaiting requested review from astjoephysics

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failure in the linking filter with new chunking in PR 998
2 participants
@mjuric @mschwamb