Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Including code to process a subset of inputs, fixing unit tests #998

Closed
wants to merge 5 commits into from
Closed

Including code to process a subset of inputs, fixing unit tests #998

wants to merge 5 commits into from

Conversation

astronomerritt
Copy link
Collaborator

Fixes #982.

  • There is now an optional command-line option, --process-subset, which allows you to process just a subset of your input orbit/parameters files. By default this is 1/1 (i.e., process everything).
  • Usage/example: --process subset 2/10 will process the second tenth of the objects in the orbit file.
  • I integrated Mario's code for this and also fixed it so it works with external ephemeris files.
  • Wrote unit tests.

Fixes #995.

  • Implemented Drew's fix for the two unit tests which fail when sorcha-addons is installed.

Review Checklist for Source Code Changes

  • Does pip install still work?
  • Have you written a unit test for any new functions?
  • Do all the units tests run successfully?
  • Does Sorcha run successfully on a test set of input files/databases?
  • Have you used black on the files you have updated to confirm python programming style guide enforcement?

@codecov Codecov
Copy link

codecov bot commented Aug 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.08%. Comparing base (9aae130) to head (954e785).
Report is 39 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #998      +/-   ##
==========================================
+ Coverage   80.89%   81.08%   +0.18%     
==========================================
  Files          69       69              
  Lines        3094     3124      +30     
==========================================
+ Hits         2503     2533      +30     
  Misses        591      591

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mschwamb
Copy link
Collaborator

@astronomerritt can you resolve conflicts?

@astronomerritt
Copy link
Collaborator Author

Done here too!

@mschwamb mschwamb requested a review from Gerenjie August 14, 2024 17:16
@mschwamb
Copy link
Collaborator

Some issues #1009

mschwamb
mschwamb requested changes Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@mschwamb mschwamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an issue ticket submitted about the performance of this PR

@astronomerritt astronomerritt mentioned this pull request Sep 3, 2024
Merged
5 tasks
@mschwamb
Copy link
Collaborator

mschwamb commented Oct 4, 2024

At this point, this PR is too far out of date, that I think we should come back to this at a later time with a fresh PR.

@mschwamb mschwamb closed this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mschwamb mschwamb mschwamb requested changes

@Gerenjie Gerenjie Awaiting requested review from Gerenjie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

process a slice of an input file Two unit tests fail if sorcha-addons is installed
2 participants
@astronomerritt @mschwamb