From db76c10a8c1d46076937e5f1241d6ada398329fd Mon Sep 17 00:00:00 2001 From: Lindsey Zylstra Date: Mon, 13 Jan 2025 16:43:37 -0800 Subject: [PATCH 1/2] More spacing on larger screens and add button group --- components/Block/Carousel/Carousel.vue | 15 +++++++ components/Block/Carousel/CarouselCard.vue | 46 ++++++++------------- types/schema/blocks/block-carousel-cards.ts | 2 + 3 files changed, 35 insertions(+), 28 deletions(-) diff --git a/components/Block/Carousel/Carousel.vue b/components/Block/Carousel/Carousel.vue index c9e809fe..22b09a0f 100644 --- a/components/Block/Carousel/Carousel.vue +++ b/components/Block/Carousel/Carousel.vue @@ -104,6 +104,8 @@ onMounted(async () => { &.slide--selected > * { opacity: 1; transform: scale(1.2); + margin-left: var(--space-4); + margin-right: var(--space-4); } } &__controls { @@ -133,4 +135,17 @@ onMounted(async () => { } } } + +@media (min-width: 1200px) { + .embla__slide { + padding-left: calc(var(--slide-spacing) + 20px); + } + + .embla__slide.slide--selected { + > * { + margin-left: var(--space-8); + margin-right: var(--space-8); + } + } +} diff --git a/components/Block/Carousel/CarouselCard.vue b/components/Block/Carousel/CarouselCard.vue index 180625e7..47092776 100644 --- a/components/Block/Carousel/CarouselCard.vue +++ b/components/Block/Carousel/CarouselCard.vue @@ -19,28 +19,13 @@ const { data: cardData } = useAsyncData(`carousel-card-${props.uuid}`, () => 'external_url', 'button_text', 'description', + { block_button_group: ['id', 'alignment'] }, { page: ['permalink'] }, { resource: ['slug'] }, ], }), ), ); - -const buttonHref = computed(() => { - if (cardData.value?.external_url) { - return cardData.value.external_url; - } - - if (cardData.value?.page?.permalink) { - return cardData.value.page.permalink; - } - - if (cardData.value?.resource?.slug) { - return `/resource/${cardData.value.resource.slug}`; - } - - return '#'; -});