FEATURE: Add cops for services #51
Open
+644
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flink
force-pushed
the
loic-add-service-cops
branch
2 times, most recently
from
af97001
to
9707cd4
Compare
Flink
force-pushed
the
loic-add-service-cops
branch
from
9707cd4
to
2a2c8bd
Compare
This patch introduces two new cops aimed at services: - Discourse/Services/EmptyLinesAroundBlocks: checks for missing empty lines around multiline blocks. It has autocorrect support. - Discourse/Services/GroupKeywords: checks for extra empty lines for service keywords (not block ones). It has autocorrect support.
Flink
force-pushed
the
loic-add-service-cops
branch
from
c4ad4c9
to
93d40fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two new cops aimed at services:
Discourse/Services/EmptyLinesAroundBlocks: checks for missing emptylines around multiline blocks. It has autocorrect support.
Discourse/Services/GroupKeywords: checks for extra empty lines forservice keywords (not block ones). It has autocorrect support.
Results can be seen here: discourse/discourse#29997