Skip to content

Commit

Permalink
Support Win32 long paths: setup.exe, dkml-package-entry.exe
Browse files Browse the repository at this point in the history
diskuv/dkcoder#2

+ Change dkml-package-entry.exe name to Diskuv.DkML.ConsoleEntrySetupExe from Diskuv.DKML.ConsoleEntrySetupExe
  • Loading branch information
Jonah Beckford committed Sep 14, 2024
1 parent f604bc6 commit a4be1fb
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 9 deletions.
1 change: 0 additions & 1 deletion .ocamlformat
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
version=0.25.1
profile=conventional
1 change: 1 addition & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## Pending

* Add `uninstall_file_onerror_exit` to API
* Enable Windows long path support for `setup.exe` and `dkml-package-entry.exe` in application manifest. Confer <https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation>

## 0.5.2

Expand Down
3 changes: 2 additions & 1 deletion installer/ml-generator/code/entry-application.manifest
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
<?xml version='1.0' encoding='UTF-8' standalone='yes'?>
<assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0" xmlns:asmv3="urn:schemas-microsoft-com:asm.v3">
<asmv3:application>
<asmv3:windowsSettings xmlns="http://schemas.microsoft.com/SMI/2019/WindowsSettings">
<asmv3:windowsSettings xmlns="http://schemas.microsoft.com/SMI/2019/WindowsSettings" xmlns:ws2="http://schemas.microsoft.com/SMI/2016/WindowsSettings">
<activeCodePage>UTF-8</activeCodePage>
<ws2:longPathAware>true</ws2:longPathAware>
</asmv3:windowsSettings>
</asmv3:application>
</assembly>
11 changes: 5 additions & 6 deletions installer/ml-generator/code/entry_assembly_manifest.ml
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,11 @@ let () =
let version_m_n_o_p =
Dkml_package_console_common.version_m_n_o_p Private_common.program_version
in
(* This generated manifest is merged with [entry-application.manifest] in `discover.ml` *)
print_endline
(Fmt.str
"<?xml version='1.0' encoding='UTF-8' standalone='yes'?>\n\
<assembly xmlns='urn:schemas-microsoft-com:asm.v1' \
manifestVersion='1.0'>\n\
\ <assemblyIdentity type=\"win32\" \
name=\"Diskuv.DKML.ConsoleEntrySetupExe\" version=\"%s\" />\n\
</assembly>"
{|<?xml version='1.0' encoding='UTF-8' standalone='yes'?>
<assembly xmlns='urn:schemas-microsoft-com:asm.v1' manifestVersion='1.0'>
<assemblyIdentity type="win32" name="Diskuv.DkML.ConsoleEntrySetupExe" version="%s" />
</assembly>|}
version_m_n_o_p)
3 changes: 2 additions & 1 deletion package/console/create/assets/manifests/setup.exe.manifest
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,9 @@
</security>
</trustInfo>
<asmv3:application>
<asmv3:windowsSettings xmlns="http://schemas.microsoft.com/SMI/2019/WindowsSettings">
<asmv3:windowsSettings xmlns="http://schemas.microsoft.com/SMI/2019/WindowsSettings" xmlns:ws2="http://schemas.microsoft.com/SMI/2016/WindowsSettings">
<activeCodePage>UTF-8</activeCodePage>
<ws2:longPathAware>true</ws2:longPathAware>
</asmv3:windowsSettings>
</asmv3:application>
</assembly>

0 comments on commit a4be1fb

Please sign in to comment.